A senior dev's blunt note on my code reviews changed my whole approach

Last month in Seattle, a senior dev on our team left a comment on my pull request that basically said 'you're fixing symptoms, not the source.' I was SO defensive at first, I spent two days annoyed. But then I actually traced through the code and realized my bug fixes were just patches on top of messy logic. I started asking 'why does this break' instead of 'how do I make it stop' on every issue. Six weeks later, my teammates actually ask for my input on architecture talks, not just bug tickets. Has anyone else gotten feedback that stung at first but turned out to be the push you needed? What did they say to you?

0 comments

0 Comments

No comments yet

Be the first to share your thoughts on this discussion.